Skip to content

Return nil if lldpd is not running (#152) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return nil if lldpd is not running (#152) #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
221ffb5
confine custom fact to running lldpd daemon
kBite May 3, 2023
ea0c308
add unit test for 'lldpd' not running
kBite May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/facter/lldp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ class MalformedDataError < StandardError; end

Facter.add(:lldp) do
confine do
Facter::Util::Resolution.which('lldpctl')
Facter::Util::Resolution.which('lldpctl') &&
File.exist?('/run/lldpd/lldpd.socket')
end

setcode do
Expand Down
11 changes: 11 additions & 0 deletions spec/unit/facter/lldp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,25 @@

context 'lldpctl not in path' do
before do
allow(File).to receive(:exist?).with('/run/lldpd/lldpd.socket').and_return(true)
allow(Facter::Util::Resolution).to receive(:which).with('lldpctl').and_return(nil)
end

it { expect(Facter.fact(:lldp).value).to eq(nil) }
end

context 'lldpd not running' do
before do
allow(File).to receive(:exist?).with('/run/lldpd/lldpd.socket').and_return(false)
allow(Facter::Util::Resolution).to receive(:which).with('lldpctl').and_return('/usr/sbin/lldpctl')
end

it { expect(Facter.fact(:lldp).value).to eq(nil) }
end

context 'valid run' do
before do
allow(File).to receive(:exist?).with('/run/lldpd/lldpd.socket').and_return(true)
allow(Facter::Util::Resolution).to receive(:which).with('lldpctl').and_return('/usr/sbin/lldpctl')
end

Expand Down