Skip to content

Conversation

rjordakiev
Copy link

Working on a change that allows respecting the order imposed by xs:sequence in schema, which is an existing issue (#1267).

Respecting the xs:group element is also of importance since there are specific cases when the sequence appears as a child of the group.

@rjordakiev
Copy link
Author

Is there any intrinsic reason that the group element is commented out and parsed as UnexpectedElement that I may be messing or it simply is obsolete for the current implementation?

@w666 w666 self-requested a review September 10, 2025 10:02
@w666
Copy link
Collaborator

w666 commented Sep 10, 2025

Could you please add some tests for this? it would help to understand the changes and lock down the implementation. Thanks.

@smokhov
Copy link
Contributor

smokhov commented Sep 11, 2025

Is there any intrinsic reason that the group element is commented out and parsed as UnexpectedElement that I may be messing or it simply is obsolete for the current implementation?

IMO, it's history the OG devs would know. Whatever was the reason, we don't need to dwell on it, and push the project forward, so thank you for your contribution.

I see in your fork you also did commit an implementation of the sequence ordering; that other branch has tests. Do they cover this group element as well? if so, then why not include it into the PR as well? It seems from your implementation group element is required to enable proper sequence ordering anyway.


public $ref?: string;

// XSD allows min(/max)Occurs, but node-soap currently only pluralizes on element level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also explain this comment in relationship to:

public $minOccurs?: string;

I am curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants