Skip to content

Do not inheritAttrs on ModalContainer #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not inheritAttrs on ModalContainer #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9664295
remove attributes from ModalContainer
FlorianWerndl Sep 12, 2024
41d91f5
fix formatting
FlorianWerndl Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"@vorms/core": "^1.1.0",
"@vue-final-modal/nuxt": "workspace:1.0.3",
"vue-final-modal": "workspace:4.5.4",
"vue-final-modal": "workspace:4.5.5",
"vue3-drag-resize": "^2.0.5"
Comment on lines -19 to 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments.

}
}
4 changes: 4 additions & 0 deletions packages/vue-final-modal/src/components/ModalsContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ const { modalsContainers, dynamicModals } = useVfm()
const uid = Symbol(__DEV__ ? 'ModalsContainer' : '')
const shouldMount = computed(() => uid === modalsContainers.value?.[0])

defineOptions({
inheritAttrs: false,
})

Comment on lines +13 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should contain only this change alone. The version updates are handled upon release/publish.

An explanation of the issue would helpful. Why does this need to be false?

modalsContainers.value.push(uid)
onBeforeUnmount(() => {
modalsContainers.value = modalsContainers.value.filter(i => i !== uid)
Expand Down
Loading