Fix imports after Nuxt 3.17.6 in dev mode #1628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Jul 17, 2025
|
|
||
| if (isDev) { | ||
| // Use require in development mode to work around Vite environment changes | ||
| adminAppModule = require('firebase-admin/app') |
There was a problem hiding this comment.
Thanks but this doesn't look like the right fix...
There was a problem hiding this comment.
Thanks for the feedback. It works, but if you got another idea let me know so I can test / try it out. What was in your mind?
There was a problem hiding this comment.
Maybe Nuxt/vite are not resolving correctly something. Sometimes some unintuitive workarounds are needed in Nuxt modules to avoid duplication or resolving the wrong version. You can see it here and in pinia modules. Good luck!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.