Skip to content

Conversation

nobiit
Copy link
Contributor

@nobiit nobiit commented Aug 18, 2025

Change summary

In case of not using VyOS APT library, tacacs build will fail

dpkg-checkbuilddeps: error: Unmet build dependencies: libssl-dev

This fix explicitly adds libssl-dev (build dependency of libpam-tacplus) in tacacs/package.toml to make the build clear, and always successful (In case of rebuilding from scratch)

You can see the dependencies in the Build-Depends section in https://github.com/vyos/libpam-tacplus/blob/master/debian/control

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7733

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Aug 18, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@dmbaturin dmbaturin added the bp/circinus Create automatic backport for circinus label Aug 21, 2025
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing build dependencies.

@dmbaturin dmbaturin merged commit fdfc4ee into vyos:current Aug 21, 2025
4 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants