-
Notifications
You must be signed in to change notification settings - Fork 40
Sync character naming template from i18n specdev #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xfq
wants to merge
1
commit into
main
Choose a base branch
from
char-naming-20250718
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be at least a space character between the unicode character and its name. This would happen with a copy-paste of the code above because there's a CR (or LF, or CRLF) between, which HTML renderers will fold into a space character. If you want the sample code to be exactly the same as that which is used to "produce output in the page", just change my space to a CR/LF/CRLF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided not to add that space, and use a padding instead. See:
.uname
and.codepoint
to style characters inline tr-design#323Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. As noted in that VERY LONG discussion, removing this space character is VERY counterintuitive. It's really unfortunate that there appears to be no clever way of treating an inline space character as if it weren't there for the CSS spacing. I do note that the template appears to have a line break following the
</bdi>
which gets folded into a space char which then increases the spacing due to the CSS. I won't fight it, but yeesh!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an LF in the
<pre>
block because we want the code to be clear, rather than having an extra long line. And there's no LF (or space) in the rendered result below.