Skip to content

Conversation

@MaillPierre
Copy link

The main manifest uses "sequence" to list the other sub-manifests used for the test suite.
"sequence" uses the property mf:entries, which is described as being used to link manifests to entries. To link manifests to other manifests, mf:include should be used.

This pull request adds "inclusion" to the context as a keyword similar to "sequence" but using mf:include. It also replaces "sequence" by "inclusion" in the main manifest.

@davidlehn
Copy link
Contributor

  • Where is the spec for the vocab? The use here and in related specs might be a bit fuzzy. I assume everyone processes these manifests as plain JSON, at least initially, to bootstrap having a JSON-LD processor.
  • I recall the data mistakenly used "sequence" when it was first written, and was later mapped to "entries", but kept as the same name to avoid having to change every test suite and implementation.
  • I always assumed "entries" values could be either a test or another manifest. Is a manifest an entry? I think that makes it a nice tree structure to process and switch based on type. And if it's a string, assume you dereference that and process what you get. Just like other JSON-LD. But I've never looked at docs on any of this!
  • Why "inclusion" instead of "includes"?
  • If this changes, it will likely break every single implementation. Might need to consider when trading off letting it stay slightly incorrect and documenting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants