Skip to content

Add remote track channelCount #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add remote track channelCount #3025

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
308a590
Add remote track channelCount
henbos Nov 26, 2024
9cde211
Merge branch 'main' into 241126_channelCount
henbos Nov 28, 2024
3579baa
Update description
henbos Nov 28, 2024
5d27f27
data-tests
henbos Nov 28, 2024
c4a49af
Merge branch 'main' into 241126_channelCount
dontcallmedom Jan 17, 2025
7475848
Fix amendments.json
dontcallmedom Jan 17, 2025
7eff351
Fix amendments.json
dontcallmedom Jan 17, 2025
20dbf35
Update amendments.json
henbos Mar 27, 2025
61999b9
Address dom comments
henbos Mar 27, 2025
becc7a3
Add MUST language
henbos Mar 27, 2025
57dbd50
nit
henbos Mar 27, 2025
135f52e
Merge branch 'main' into 241126_channelCount
henbos Mar 27, 2025
7f3c5eb
Adapt amendments to appended rows
dontcallmedom Mar 27, 2025
3e03beb
Merge branch 'main' into 241126_channelCount
henbos Mar 28, 2025
577d9cb
Clarify and take stereo flag into account
henbos Mar 28, 2025
ced7c79
Merge branch '241126_channelCount' of https://github.com/henbos/webrt…
henbos Mar 28, 2025
953516d
Local SDP
henbos Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,5 +1242,22 @@
"web-platform-tests/wpt#48361"
]
}
],
"remote-track-settings-channel-count": [
{
"description": "Add channelCount to remote track settings",
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 52,
"pr": 3025,
"tests": [
"webrtc/RTCRtpEncodingParameters-codec-opus-stereo.https.html"
],
"testUpdates": [
"web-platform-tests/wpt#48599",
"web-platform-tests/wpt#49392"
]
}
]
}
1 change: 1 addition & 0 deletions base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15948,6 +15948,7 @@ <h4 id="x9-3-1-mediatracksupportedconstraints-mediatrackcapabilities-mediatrackc
double rounded to the tenth decimal place.
</td>
</tr>
<div id="remote-track-settings-channel-count"><!-- ammendment --></div>
</tbody>
</table>
<p class="no-test-needed">
Expand Down
15 changes: 15 additions & 0 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16610,6 +16610,21 @@ <h4>
double rounded to the tenth decimal place.
</td>
</tr>
<div id="remote-track-settings-channel-count">
<tr id="def-constraint-channelCount">
<th data-tests="RTCRtpEncodingParameters-codec-opus-stereo.https.html">
channelCount
</th>
<td>
{{ConstrainULong}}
</td>
<td>
As a setting, this is the number of channels of the latest
audio frame received, reflecting the number of
{{RTCRtpCodec/channels}} that the decoder outputted.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from Youenn: make this more clear that you MUST do what the decoder is capable of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to refresh our memories about the conclusion: we have go-ahead to return 2 here and as per discussion, saying MUST here was preferred.

I updated this sentence to say "A stereo capable decoder MUST produce stereo and return the value 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WPT also reflects the "always do stereo on the receiving track" decision.

</td>
</tr>
</div>
</tbody>
</table>
<p class="no-test-needed">
Expand Down
Loading