feat: simpler routing info #2514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
adklempner
force-pushed
the
feat/simpler-routing-info
branch
from
1f5a456 to
01cd002
Compare
fryorcraken
approved these changes
Jul 22, 2025
| } | ||
|
|
||
| /** | ||
| * @deprecated will be removed |
Collaborator
There was a problem hiding this comment.
@weboko mentioned it might be good to move this to core. I have no strong opinion on the matter.
Comment on lines
+125
to
+131
| public pubsubTopic: PubsubTopic; | ||
| public shardId: ShardId; | ||
|
|
||
| protected constructor( | ||
| public networkConfig: NetworkConfig, | ||
| public pubsubTopic: PubsubTopic, | ||
| public shardId: ShardId | ||
| ) {} | ||
| pubsubTopic: PubsubTopic, | ||
| shardId: ShardId |
Collaborator
There was a problem hiding this comment.
Why the change? When you don't do it for networkConfig?
| } | ||
| } | ||
|
|
||
| export function isAutoShardingRoutingInfo( |
Collaborator
There was a problem hiding this comment.
Can you check if those are actually used? I wonder if they are actually needed.
weboko
reviewed
Jul 28, 2025
| export * from "./local_storage.js"; | ||
| export * from "./sharding.js"; | ||
| export * from "./health_status.js"; | ||
| export type { ShardInfo } from "./sharding.js"; |
Collaborator
There was a problem hiding this comment.
it is covered by the line above: export * from "./sharding.js";
Suggested change
| export type { ShardInfo } from "./sharding.js"; |
weboko
reviewed
Jul 28, 2025
| numShardsInCluster | ||
| }; | ||
| const Shard = [ | ||
| AutoShardingRoutingInfo.fromContentTopic(ContentTopic, networkConfig) |
Collaborator
There was a problem hiding this comment.
why won't you simply use createRoutingInfo in these types of places?
weboko
reviewed
Jul 28, 2025
| clusterId: TestClusterId, | ||
| numShardsInCluster: TestNumShardsInCluster | ||
| }; | ||
| export const TestShardIndex = AutoShardingRoutingInfo.fromContentTopic( |
Collaborator
There was a problem hiding this comment.
can't you get it from TestRoutingInfo?
Collaborator
|
@adklempner confirmed this PR can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
There was some unnecessary code leftover after RouterInfo refactor
Solution
Consolidate core sharding functions into unified routing info classes:
isAutoShardingRoutingInfo)formatPubsubTopic,ensureValidContentTopic,contentTopicToShardIndexintorouting_info.tscreateRoutingInfo()patternNotes
contentTopicToPubsubTopiccreateRoutingInfo(networkConfig, { contentTopic }).pubsubTopicChecklist