Skip to content

Conversation

fryorcraken
Copy link
Collaborator

Problem / Description

version is used to store payload encryption information. It is actually useless:

  • developer should attempt to decrypt messages based on usage of content topic
  • failed decryption is cheap

And mixes up routing concern (Waku Message) with application concerns (payload encryption).

Solution

Stop reading version from messages in a phased removal.

Notes

  • Resolves
  • Related to

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

Phased out of the removal of `version`.

Do not read it anymore.

`version` is used for encryption purposes, it is not a routing concern and hence should not be set on the Waku Message (which itself is a routing artefact)
Copy link

github-actions bot commented Sep 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 95.8 KB (-0.1% 🔽) 2 s (-0.1% 🔽) 1.5 s (+6.17% 🔺) 3.4 s
Waku Simple Light Node 147.22 KB (+0.02% 🔺) 3 s (+0.02% 🔺) 2.4 s (+40.21% 🔺) 5.3 s
ECIES encryption 22.47 KB (-0.22% 🔽) 450 ms (-0.22% 🔽) 615 ms (+4.46% 🔺) 1.1 s
Symmetric encryption 21.89 KB (-0.29% 🔽) 438 ms (-0.29% 🔽) 352 ms (-47.57% 🔽) 790 ms
DNS discovery 52.1 KB (-0.05% 🔽) 1.1 s (-0.05% 🔽) 795 ms (-31.72% 🔽) 1.9 s
Peer Exchange discovery 52.8 KB (-0.05% 🔽) 1.1 s (-0.05% 🔽) 1.4 s (+52.52% 🔺) 2.4 s
Peer Cache Discovery 46.62 KB (+0.11% 🔺) 933 ms (+0.11% 🔺) 1.1 s (+42.54% 🔺) 2 s
Privacy preserving protocols 77.04 KB (+0.03% 🔺) 1.6 s (+0.03% 🔺) 1.5 s (+18.74% 🔺) 3 s
Waku Filter 79.6 KB (-0.06% 🔽) 1.6 s (-0.06% 🔽) 1.7 s (+67.36% 🔺) 3.3 s
Waku LightPush 77.71 KB (-0.15% 🔽) 1.6 s (-0.15% 🔽) 1.2 s (+3.53% 🔺) 2.7 s
History retrieval protocols 83.48 KB (-0.12% 🔽) 1.7 s (-0.12% 🔽) 1.5 s (+53.22% 🔺) 3.2 s
Deterministic Message Hashing 28.84 KB (-0.14% 🔽) 577 ms (-0.14% 🔽) 644 ms (-24.41% 🔽) 1.3 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant