Typecheck server code in build and CI #2709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning `npx tsc` Fixes #2384
4 tasks
sodic
reviewed
May 5, 2025
Comment on lines
+168
to
+170
| - name: Ensure examples/crud-testing compiles and builds | ||
| if: matrix.os == 'ubuntu-22.04' || matrix.os == 'macos-latest' | ||
| run: ./tools/ensure_app_compiles_and_builds.sh ./examples/crud-testing |
There was a problem hiding this comment.
Nice thinking!
Hm, but could we maybe instead move the Crud stuff to todoApp? This goes towards the effort of having one "end all be all" testing app.
|
Closed in favor of #2739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2672 (review)
Description
Fixes #2384
Moves the
ensure_app_compiles_and_builds.shscript to thewaspcfolder, and in CI it will run it againsttodoAppandcrud-testing.It also adds
tsc --buildto thenpm run bundleof the generated server.Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects
waspc, make sure you satisfy the following:ChangeLog.mdwith description of the change this PR introduces.waspcversion inwaspc.cabalto reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.