Allow id-card authentication when Extended Key Usage is not present in certificate #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenzik
force-pushed
the
WE2-1026
branch
2 times, most recently
from
45ad503 to
6972af4
Compare
svenzik
force-pushed
the
WE2-1026
branch
6 times, most recently
from
938302b to
30f1eed
Compare
mrts
reviewed
Apr 11, 2025
src/test/java/eu/webeid/security/testutil/AuthTokenValidators.java
Outdated
Show resolved
Hide resolved
mrts
reviewed
Apr 11, 2025
src/test/java/eu/webeid/security/validator/AuthTokenCertificateBelgianIdCardTest.java
Outdated
Show resolved
Hide resolved
svenzik
force-pushed
the
WE2-1026
branch
2 times, most recently
from
76c742c to
3f16cd0
Compare
mrts
reviewed
Apr 14, 2025
src/test/java/eu/webeid/security/validator/AuthTokenCertificateBelgianIdCardTest.java
Outdated
Show resolved
Hide resolved
mrts
approved these changes
Apr 14, 2025
…n certificate WE2-1026 Signed-off-by: Sven Mitt <[email protected]>
WE2-1026 Signed-off-by: Sven Mitt <[email protected]>
WE2-1026 Signed-off-by: Sven Mitt <[email protected]>
metsma
approved these changes
May 13, 2025
mrts
reviewed
May 13, 2025
| throw new UserCertificateMissingPurposeException(); | ||
| // Digital Signature extension present, but Extended Key Usage extension not present, | ||
| // assume it is an authentication certificate (e.g. Luxembourg eID). | ||
| return; |
There was a problem hiding this comment.
Line 68 has a debug log message, it is needed here as well before return for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Mitt [email protected]