Skip to content

NFC-47 NFC support for web-eid example #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

NFC-47 NFC support for web-eid example #83

merged 1 commit into from
Oct 24, 2025

Conversation

@SanderKondratjevNortal
Copy link

@SanderKondratjevNortal SanderKondratjevNortal commented Jul 2, 2025

Signed-off-by: Sander Kondratjev [email protected]

@SanderKondratjevNortal SanderKondratjevNortal changed the base branch from main to web-eid-mobile August 13, 2025 12:26
@SanderKondratjevNortal SanderKondratjevNortal force-pushed the NFC-47 branch 2 times, most recently from 1da9ec5 to d3edcb7 Compare September 23, 2025 07:22
@SanderKondratjevNortal SanderKondratjevNortal force-pushed the NFC-47 branch 2 times, most recently from b519373 to 81dea4d Compare September 29, 2025 08:49
mrts
mrts requested changes Oct 14, 2025
View reviewed changes
mrts
mrts requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@mrts mrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now apart from the suggested changes, thanks for your great work!

As discussed, also consider making mobile code configurable both to make it easier to discern and possibly serve a real business need not to use it in certain circumstances.

mrts
mrts requested changes Oct 21, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mrts mrts merged commit b0f90da into web-eid-mobile Oct 24, 2025
8 checks passed
@mrts mrts deleted the NFC-47 branch October 24, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrts mrts mrts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SanderKondratjevNortal @mrts