fix: treat module as normal variable in ESM
#1260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of the module variable in ES modules by preventing extra parser transformations when ESM syntax is present. The fix ensures that when building libraries in ESM format, the module variable is treated as a normal variable rather than being transformed by CommonJS-specific parsers.
- Updates JavaScript parser configuration to skip CommonJS exports handling in ESM context
- Adds comprehensive integration tests for
modulevariable handling in both ESM and CJS formats - Removes the
"type": "module"package.json field from a test to ensure proper testing of mixed environments
Reviewed Changes
Copilot reviewed 12 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Adds commonjs.exports: 'skipInEsm' parser option for ESM format |
| packages/core/tests/snapshots/config.test.ts.snap | Updates test snapshots to reflect new parser configuration |
| tests/integration/parser-javascript/module/ | New test suite with files to verify module variable handling in ESM vs CJS |
| tests/integration/parser-javascript/api-plugin/ | New test for API plugin parser behavior |
| tests/integration/format/index.test.ts | Updates existing test and adds new test case for module handling |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
second (final) step after web-infra-dev/rspack#11744.
forbid extra parser to handle
modulevar if ESM syntax is present, common usage and user expectation in package building.Related Links
Checklist