feat(browser): support modules in BrowserRequirePlugin
#11822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
team
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new modules option to the BrowserRequirePlugin to support direct module mapping, making it more convenient to use custom loaders in the Rspack browser environment.
Key changes:
- Adds a
modulesoption that allows direct mapping from module specifiers to JavaScript objects - Makes the
executeoption optional whenmodulesis provided - Updates documentation to explain both usage patterns
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/rspack/src/browser/BrowserRequirePlugin.ts | Implements the modules option with module mapping logic and fallback behavior |
| packages/rspack/src/browser/index.ts | Fixes export path for BrowserRequirePlugin |
| website/docs/en/api/javascript-api/browser.mdx | Adds English documentation for the new modules option |
| website/docs/zh/api/javascript-api/browser.mdx | Adds Chinese documentation for the new modules option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
📦 Binary Size-limit
🎉 Size decreased by 384bytes from 47.89MB to 47.89MB (⬇️0.00%) |
CodSpeed Performance ReportMerging #11822 will not alter performanceComparing Summary
|
h-a-n-a
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This option makes it more convenient to use custom loaders in rspack browser
Checklist