test: skip flaky test cases #11827
Merged
test: skip flaky test cases #11827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
📦 Binary Size-limit
🎉 Size decreased by 1.63KB from 47.89MB to 47.89MB (⬇️0.00%) |
CodSpeed Performance ReportMerging #11827 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily skips two flaky tests in CI that are causing build instability. The tests will be tracked in separate GitHub issues for future fixes.
- Adds a test filter to skip a watch case test on Windows with native watcher enabled
- Skips an e2e test for lazy compilation with persistent cache
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js | Adds platform-specific test filter to skip test on Windows with native watcher |
| tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts | Skips flaky e2e test using test.skip() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
hardfist
reviewed
Oct 10, 2025
tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip two flaky tests in CI Temporally, they will be tracked in two issues, and fixed later
Related links
Checklist