-
-
Notifications
You must be signed in to change notification settings - Fork 11
chore: remove SIGTERM event handler
#680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the worker termination handling by moving SIGTERM signal management from manual lifecycle management to Tinypool's built-in teardown hook. The changes simplify the code by removing the module-level onExit function and delegating worker termination to the pool manager.
Key changes:
- Exported a new
teardownfunction to be called by Tinypool when terminating workers - Removed manual SIGTERM handler registration/deregistration from the test execution lifecycle
- Configured the forks pool to use the new teardown hook via the
teardown: 'teardown'option
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/runtime/worker/index.ts | Removed module-level onExit function and manual SIGTERM handler management; added exported teardown function for Tinypool lifecycle integration |
| packages/core/src/pool/forks.ts | Configured Tinypool to use the exported teardown function by adding teardown: 'teardown' to pool options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SIGTERM event handler
Summary
SIGTERMevent handler which will cause the main process unexpected exit when the child process exit timeout.exithandler to detect unexpected exit events that occur before the test ends.rstest will tigger
exitevent inSIGTERMevent, and the following code in test will cause main process unexpected exit with code 0.Related Links
Checklist