Skip to content

Fix renderer crash in showPopover#58631

Merged
jcscottiii merged 1 commit intomasterfrom
chromium-export-cl-7676426
Mar 20, 2026
Merged

Fix renderer crash in showPopover#58631
jcscottiii merged 1 commit intomasterfrom
chromium-export-cl-7676426

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 20, 2026

It's possible for focus/blur handlers to modify the popover
attribute during the auto-focus routine. Avoid that crash.

Fixed: 492780658
Change-Id: If27910c0b64efa132ff18595a9893744d1e70414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676426
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602381}

It's possible for focus/blur handlers to modify the popover
attribute during the auto-focus routine. Avoid that crash.

Fixed: 492780658
Change-Id: If27910c0b64efa132ff18595a9893744d1e70414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676426
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602381}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

@jcscottiii @DanielRyanSmith The tests added in this PR cause Firefox to become unresponsive, which is considered a "crash". This, in turn, fails wpt-firefox-* because mozcrash doesn't play well with the recently upgraded mozlog (#58653).

Let's just merge, thanks.

@jcscottiii jcscottiii merged commit 7aaf43a into master Mar 20, 2026
25 of 28 checks passed
@jcscottiii jcscottiii deleted the chromium-export-cl-7676426 branch March 20, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants