Merged
Conversation
It's possible for focus/blur handlers to modify the popover attribute during the auto-focus routine. Avoid that crash. Fixed: 492780658 Change-Id: If27910c0b64efa132ff18595a9893744d1e70414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676426 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1602381}
e079767 to
8c71f33
Compare
wpt-pr-bot
approved these changes
Mar 20, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Contributor
|
@jcscottiii @DanielRyanSmith The tests added in this PR cause Firefox to become unresponsive, which is considered a "crash". This, in turn, fails Let's just merge, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for focus/blur handlers to modify the popover
attribute during the auto-focus routine. Avoid that crash.
Fixed: 492780658
Change-Id: If27910c0b64efa132ff18595a9893744d1e70414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676426
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602381}