Fix: IS_IN_SET with multiple values #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strkeys is a map object (a lazy iterator in Python 3, unlike Python 2 where it returned a list). This means If you try to check membership with **in**, it exhausts the iterator progressively, this leads to very funny errors and sometimes the validator would seem to work correctly depending on the order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strkeys is a map object (a lazy iterator in Python 3, unlike Python 2 where it returned a list). This means If you try to check membership with in, it exhausts the iterator progressively, this leads to very funny errors and sometimes the validator would seem to work correctly depending on the order.
Ohh yeah this Fixes #732 I didn't know this was reported, his suggestion would also work