Skip to content

Add an error message when assigning Translatables with mismatching $locale #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add an error message when assigning Translatables with mismatching $locale #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dea493
Add an error message when assigning Translatables with mismatching $l…
MalteWunsch Sep 17, 2025
bcbc7b3
Fix CS with PHP-CS-Fixer
MalteWunsch Sep 17, 2025
1ed58f0
Fix Name of config setting
MalteWunsch Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Doctrine/PersistentTranslatable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Doctrine\Common\Collections\Selectable;
use Doctrine\ORM\UnitOfWork;
use Exception;
use InvalidArgumentException;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use ReflectionClass;
Expand Down Expand Up @@ -97,6 +98,10 @@ public function __construct(
$this->valueForEjection = $currentValue;
} elseif ($currentValue instanceof Translatable) {
$currentValue->copy($this);

if (!isset($this->primaryValue) && !(new ReflectionProperty($this, 'primaryValue'))->isInitialized($this)) {
throw new InvalidArgumentException('An object of class '.$class.' has no value set (not even NULL) for the property "'.$this->translatedProperty->getName().'" for the primary locale "'.$primaryLocale.'" configured for this class (e.g. via `#[Polyglot\Locale(primary: "'.$primaryLocale.'")]`). Check any assignments of `new Translatable`s to the property "'.$this->translatedProperty->getName().'": If a $locale is passed, it differs from the primary locale configured the class ("'.$primaryLocale.'"). If no $locale is passed, the primary locale configured the class ("'.$primaryLocale.'") differs from the application default locale (configured via `webfactory_polyglot.defaultLocale`).');
}
} else {
$this->primaryValue = $currentValue;
}
Expand Down