Add CXX child crate #18
Conversation
|
Is the plan for dcsctp to be an alternative to https://github.com/sctplab/usrsctp or https://github.com/webrtc-rs/sctp-proto |
boivie
force-pushed
the
feature-cxx
branch
4 times, most recently
from
e365ee9 to
c1a35c5
Compare
This adds CXX FFI for the dcSCTP rust library to integrate it into a C++ application.
To avoid polluting the default namespace.
| @@ -0,0 +1 @@ | |||
| /examples/main | |||
There was a problem hiding this comment.
Could you move this to the top level .gitignore instead? Makes it easier to maintain.
|
|
||
| fn delete_socket(socket: *mut DcSctpSocket) { | ||
| if !socket.is_null() { | ||
| unsafe { |
There was a problem hiding this comment.
Add a // SAFETY: ... comment explaining why this is safe
| if !socket.is_null() { | ||
| unsafe { | ||
| // Re-take ownership of the Box and drop it. | ||
| let _ = Box::from_raw(socket); |
There was a problem hiding this comment.
Could you do this instead?
drop(Box::from_raw(socket));
| #[derive(Debug)] | ||
| enum SocketState { | ||
| Closed, | ||
| Connecting, | ||
| Connected, | ||
| ShuttingDown, | ||
| } | ||
|
|
||
| extern "Rust" { | ||
| type DcSctpSocket; |
There was a problem hiding this comment.
Is it not possible to re-export dcsctp::api::SocketState here? Why do you need to create a duplicate inside the ffi module?
...but in that case I think you would need to return Box<SocketState> from state().
| } | ||
| } | ||
|
|
||
| unsafe fn state(socket: *const DcSctpSocket) -> ffi::SocketState { |
There was a problem hiding this comment.
Can you take a &DcSctpSocket instead of *const DcSctpSocket?
| assert!(!socket.is_null()); | ||
| &*socket | ||
| }; | ||
| match socket.0.state() { |
There was a problem hiding this comment.
Is this part unsafe? Do you need the whole function block to be unsafe or can you limit it?
| } | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Is this needed? It's pub so why would it complain about being unused? Does this have to be pub by the way?
3 participants
It currently has a single function, to query the library's version, to validate that the C++ FFI is working correctly.