Skip to content

Fix registration when useEmailAsLogin is true #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix registration when useEmailAsLogin is true #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions models/forms/RegistrationForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public function registerUser($performValidation = true)
}

$user = new User();
$user->username = $this->username;
$user->password = $this->password;

if ( Yii::$app->getModule('user-management')->useEmailAsLogin )
Expand Down Expand Up @@ -119,10 +120,6 @@ public function registerUser($performValidation = true)
$user->username = $this->username;
Copy link

@colesnic89 colesnic89 Jun 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really necessary? the whole else block.

}
}
else
{
$user->username = $this->username;
}


if ( $user->save() )
Expand Down