-
Notifications
You must be signed in to change notification settings - Fork 7
SCA-3061-support-CLI #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCA-3061-support-CLI #115
Conversation
# Conflicts: # wss-agent-api/src/main/java/org/whitesource/agent/api/model/DependencyType.java
…nceStatusResult to include project events
📝 WalkthroughWalkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
wss-agent-api/src/main/java/org/whitesource/agent/api/model/ProjectEvents.java (2)
5-5
: Consider renaming toProjectEvent
(singular).The class name
ProjectEvents
suggests a collection, but it represents a single project event. SinceAsyncCheckPolicyComplianceStatusResult
usesCollection<ProjectEvents>
, renaming toProjectEvent
would make the relationship clearer:Collection<ProjectEvent>
.
5-54
: Consider addingequals()
,hashCode()
, andtoString()
methods.Since instances of this class are used in a
Collection
, overriding these methods would be beneficial for debugging and proper collection behavior, especially if you need to compare or search for specificProjectEvents
instances.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
wss-agent-api/src/main/java/org/whitesource/agent/api/dispatch/AsyncCheckPolicyComplianceStatusResult.java
(3 hunks)wss-agent-api/src/main/java/org/whitesource/agent/api/model/ProjectEvents.java
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
**/*
: - Feedback will only be given on issues that could cause bugs or involve very bad practices.
- Comments will be kept concise and focused on critical areas.
Files:
wss-agent-api/src/main/java/org/whitesource/agent/api/dispatch/AsyncCheckPolicyComplianceStatusResult.java
wss-agent-api/src/main/java/org/whitesource/agent/api/model/ProjectEvents.java
🧬 Code graph analysis (1)
wss-agent-api/src/main/java/org/whitesource/agent/api/dispatch/AsyncCheckPolicyComplianceStatusResult.java (1)
wss-agent-api/src/main/java/org/whitesource/agent/api/model/ProjectEvents.java (1)
ProjectEvents
(5-55)
🔇 Additional comments (6)
wss-agent-api/src/main/java/org/whitesource/agent/api/dispatch/AsyncCheckPolicyComplianceStatusResult.java (3)
3-6
: LGTM!The imports are correctly added for the new field type.
18-18
: LGTM!The new field follows the existing pattern in this class where fields are nullable by default.
38-44
: LGTM!The getter and setter methods are correctly implemented.
wss-agent-api/src/main/java/org/whitesource/agent/api/model/ProjectEvents.java (3)
1-7
: LGTM!The class structure and serialization setup are correct.
9-22
: LGTM!The fields and constructors are correctly implemented.
24-54
: LGTM!The getters and setters are correctly implemented.
Summary by CodeRabbit