Skip to content

Fixed issue with migrations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ecto_3.0
Choose a base branch
from
Open

Fixed issue with migrations #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/connection/query/expression.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,16 @@ defmodule MssqlEcto.Connection.Query.Expression do
["0x", Base.encode16(binary, case: :lower)]
end

# Re-alias field name so that it is returned by :odbc
def expr(
%Ecto.Query.Tagged{value: {{:., _, [{:&, _, [idx]}, field]}, _, []} = other, type: type},
sources,
query
)
when is_atom(field) do
["CAST(", expr(other, sources, query), " AS ", tagged_to_db(type) | ") AS #{field}"]
end

def expr(%Ecto.Query.Tagged{value: other, type: type}, sources, query) do
["CAST(", expr(other, sources, query), " AS ", tagged_to_db(type) | ")"]
end
Expand Down Expand Up @@ -258,8 +268,8 @@ defmodule MssqlEcto.Connection.Query.Expression do

defp tagged_to_db({:array, type}), do: [tagged_to_db(type), ?[, ?]]
# Always use the largest possible type for integers
defp tagged_to_db(:id), do: "int"
defp tagged_to_db(:integer), do: "int"
defp tagged_to_db(:id), do: "bigint"
defp tagged_to_db(:integer), do: "bigint"
defp tagged_to_db(type), do: ecto_to_db(type)

def window_exprs(kw, sources, query) do
Expand Down