Skip to content

Conversation

@JohnyTheCarrot
Copy link
Contributor

No description provided.

@JohnyTheCarrot JohnyTheCarrot requested review from a team and advaith1 May 17, 2024 11:40
@JohnyTheCarrot JohnyTheCarrot self-assigned this May 17, 2024
@JohnyTheCarrot JohnyTheCarrot requested review from a team, Yomanz and mason-rogers and removed request for a team and Yomanz May 17, 2024 11:40
@JohnyTheCarrot JohnyTheCarrot changed the base branch from development to chore/update-api-types May 17, 2024 11:48
@Yomanz Yomanz requested review from tylergeorges and removed request for advaith1 October 22, 2024 18:10
Copy link
Member

@Yomanz Yomanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, just a few questions

/>
{answer.poll_media.emoji && (
<Styles.AnswerEmoji
emojiName={answer.poll_media.emoji.name ?? "Unknown"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be localised

function durationFormatter(
isShort: boolean,
value: unknown,
lng: unknown,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using unknown here?

overflow: "hidden",
});

const ANSWER_BAR_Z_INDEX = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add this as a theme zIndex token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants