Skip to content

fix: add a default sourceURL to aid debugging #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maartenbreddels wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add a default sourceURL to aid debugging #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions js/src/VueTemplateRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ function createComponentObject(model, parentView) {
const isTemplateModel = model.get('template') instanceof TemplateModel;
const templateModel = isTemplateModel ? model.get('template') : model;
const template = templateModel.get('template');
const vuefile = readVueFile(template);
const sourceCodeFile = `VUE_TEMPLATE_SCRIPT_${model.cid}`;
const vuefile = readVueFile(template, sourceCodeFile);

const css = model.get('css') || (vuefile.STYLE && vuefile.STYLE.content);
const cssId = (vuefile.STYLE && vuefile.STYLE.id);
Expand Down Expand Up @@ -313,7 +314,7 @@ function aliasRefProps(model) {
}), {});
}

function readVueFile(fileContent) {
function readVueFile(fileContent, sourceURL) {
const component = parseComponent(fileContent, { pad: 'line' });
const result = {};

Expand All @@ -327,7 +328,15 @@ function readVueFile(fileContent) {
const module = {
exports: {}
};
const scriptFunction = new Function('module', 'exports', content);
/*
Add sourceURL directive - this helps browser dev tools show better error locations.
But only add it if not already present in the content (users can add it themselves if they want).
*/
const hasSourceURL = /\/\/#\s*sourceURL\s*=/i.test(content);
const contentWithScriptPath = hasSourceURL
? content
: content + `\n//# sourceURL=${sourceURL}`;
const scriptFunction = new Function('module', 'exports', contentWithScriptPath);
scriptFunction(module, module.exports);
result.SCRIPT = module.exports;
} catch (error) {
Expand Down