Skip to content

Conversation

daniel-zint
Copy link
Contributor

No description provided.

Cannot write attributes so far.
* main:
  more fixes
  Fix Linux compilation issue.
  Fix MSVC compilation issues.
  Update attribute readme.
  Remove public access to attribute through accessor.
  Add examples for how to use std::visit with the MeshAttributeHandle.
  Add CMake 4.0 hack.
  Remove the handles map from the TypedAttributeManager.
  Remove "value_type" from TypedAttributeHandle.
  Add attribute readme.
@daniel-zint daniel-zint marked this pull request as ready for review April 6, 2025 19:46
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (3b5cb08) to head (1045eb7).

Files with missing lines Patch % Lines
src/wmtk/io/MshWriter.cpp 92.13% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   73.37%   73.44%   +0.07%     
==========================================
  Files         479      480       +1     
  Lines       23971    24063      +92     
  Branches     2723     2733      +10     
==========================================
+ Hits        17588    17673      +85     
- Misses       6383     6390       +7     
Flag Coverage Δ
wildmeshing 73.44% <92.30%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* main:
  adding check for removing attributes affecting multimesh
  trying to run extra testing on attributes after removing a mesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant