Dzint/simplicial embedding app #859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot write attributes so far.
* main: more fixes Fix Linux compilation issue. Fix MSVC compilation issues. Update attribute readme. Remove public access to attribute through accessor. Add examples for how to use std::visit with the MeshAttributeHandle. Add CMake 4.0 hack. Remove the handles map from the TypedAttributeManager. Remove "value_type" from TypedAttributeHandle. Add attribute readme.
* main: adding check for removing attributes affecting multimesh trying to run extra testing on attributes after removing a mesh
More testing and integration tests are required but it should work now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 73.37% 74.23% +0.86%
==========================================
Files 479 481 +2
Lines 23971 24180 +209
Branches 2723 2748 +25
==========================================
+ Hits 17588 17950 +362
+ Misses 6383 6230 -153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.