General Fixes #56
Open
General Fixes #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: shellcheck fixes
fix: additional fixes
…829bf9a575aa3 [Snyk] Security upgrade docker from latest to 27.5.0-dind-alpine3.21
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE321-EXPAT-9459843 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732740 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732740 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732743 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732743
…nyk-fix-8994dbf363bbd972bbd011ca325305dd
…011ca325305dd [Snyk] Security upgrade docker from 27.5.0-dind-alpine3.21 to 27.5.1-dind-alpine3.21
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE321-EXPAT-9459843 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732740 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732740 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732743 - https://snyk.io/vuln/SNYK-ALPINE321-OPENSSH-8732743
…181d828d64a0d [Snyk] Security upgrade docker from 27.5.1-dind-alpine3.21 to 28.2.2-dind-alpine3.21
Replace -S flag with -s flag to run crond in single-user mode. This prevents "can't set groups: Operation not permitted" errors since su-exec already handles the user switching to docker user. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix shellcheck warning in entrypoint.sh (add -r flag to read command) - Fix incorrect source URL in Dockerfile (was pointing to alertmanager-discord) - Update docker-compose.yml to version 3.8 and change config volume to read-only - Update GitHub Actions to use latest action versions for better security and features - Remove invalid -s flag from crond CMD (already fixed in previous commit) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
BusyBox v1.37.0 crond doesn't support the -s flag that was attempted in previous versions. This fix adds argument filtering in entrypoint.sh to gracefully handle and remove any -s flags passed to crond, preventing the "unrecognized option: s" error. The solution maintains all previous fixes including proper user switching via su-exec and running crond as root for cron job execution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… the CMD instruction. Docker doesn't perform shell variable expansion in the exec form of CMD.
The issue was that BusyBox crond was trying to interpret subdirectories in /opt/crontab as usernames. This fix: - Installs the generated crontab to /etc/crontabs/docker where BusyBox expects user crontab files - Updates the crond command to use /etc/crontabs instead of /opt/crontab - Ensures proper permissions (600) on the crontab file This resolves the "no such user" errors for 'crontab' and 'jobs' directories. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.