Fix URL recognition #110
Draft
Fix URL recognition #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! Complex patterns are a bit sketchy to me, I'll have to look more into the oil-specific problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pattern used to recognize and strip URL schemes so that paths starting with
oil://,oil-ssh://and alike are recognized.Also I can't think of an example where a URL starting with a scheme is relative, so I treated them all as absolute ones. This fixes the (newly emerged) problem withoil-sshwhere it's likeoil-ssh://user@host/path.Well
oil://...URLs do work like that. Idk if people use it like that instead of just sending the directory though. Any further ideas are welcome.