fix(core)!: changed the order expected from open #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inline with documentation and the way `diff` expects it's return values. This is a breaking change, however, I think it will mostly affect hooks, not the core functionality. Namely this will change the value passed for `winnr` to `post_open` and may cause `block_end` to not be called. This also only people who were using `open` as a function, rather than a string, and have already swapped the two values.
It was previously stated as `string[]`, but the actual type passed to `open` is `Flatten.BufInfo[]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inline with documentation and the way
diffexpects it's returnvalues.
This is a breaking change, however, I think it will mostly affect hooks,
not the core functionality. Namely this will change the value passed for
winnrtopost_openand may causeblock_endto not be called.This also only people who were using
openas a function, rather than astring, and have already swapped the two values.
Also updated type of
filesin README. This is not a breaking change as using the argument as astring[]will have resulted in an error.