WIP: Attempt to automate initial bootstrap without need to run init-letsencrypt.sh manually#94
Open
andrius wants to merge 4 commits intowmnnd:masterfrom
Open
WIP: Attempt to automate initial bootstrap without need to run init-letsencrypt.sh manually#94andrius wants to merge 4 commits intowmnnd:masterfrom
init-letsencrypt.sh manually#94andrius wants to merge 4 commits intowmnnd:masterfrom
Conversation
- Created `Dockerfile` for nginx; - Downloading `options-ssl-nginx.conf` and `ssl-dhparams.pem` during docker build phase; - Relevant part in the `app.conf` updated; - Creating temp SSL certificate through `docker-entrypoint.sh` when nginx service is starting;
- certbot container waiting for healthy nginx container;
- during startup of the nginx container:
- an initial certificate get created;
- it starts nginx daemon and await for the certbot container, then
removing temporally certificate;
- it does start a "API" that allow certbot to reload nginx daemon;
-
|
Is there a plan to accept this pull request? |
|
if domains were an array, the init-letsencrypt.sh will failed, it just handled the first domain in array. ### no for loop here.
echo "### Creating dummy certificate for $domains ..."
path="/etc/letsencrypt/live/$domains"
mkdir -p "$data_path/conf/live/$domains"
docker-compose run --rm --entrypoint "\
openssl req -x509 -nodes -newkey rsa:$rsa_key_size -days 1\
-keyout '$path/privkey.pem' \
-out '$path/fullchain.pem' \
-subj '/CN=localhost'" certbot
echo |
|
Also need to update README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some my project I do need to fully automate SSL certificate creation without user intervention. Idea is to move
init-letsencrypt.shand tune up scripts so initial certificates will be created automatically.Steps:
docker-compose.ymlor create aDockerfileso certbot service won't start without "healthy" nginx service;Dockerfilefor nginx service, add adocker-entrypoint.sh, that replicate most of theinit-letsencrypt.shlogic:nginxlinux service and remove created SSL certificate right after that;certbotdocker service and request certificate first time;.envfile;README.md.