Support for custom flash option byte on NXP S32K14xx#697
Open
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Support for custom flash option byte on NXP S32K14xx#697dgarske wants to merge 1 commit intowolfSSL:masterfrom
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for customizing the Flash Option Byte (FOPT) on NXP S32K14xx microcontrollers. The FOPT value controls hardware features like the RESET pin configuration and NMI interrupt settings.
Changes:
- Added a configurable
WOLFBOOT_FOPTmacro with default value0xFFto allow override via compiler flags - Updated documentation with detailed FOPT bit field reference table and usage examples
- Added commented configuration examples across all S32K14x variant config files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hal/s32k1xx.c | Introduced WOLFBOOT_FOPT macro to replace hardcoded flash option byte value |
| docs/Targets.md | Added comprehensive documentation table describing FOPT bit fields and usage |
| config/examples/nxp-s32k148.config | Added commented example for FOPT override configuration |
| config/examples/nxp-s32k146.config | Added commented example for FOPT override configuration |
| config/examples/nxp-s32k144.config | Added commented example for FOPT override configuration |
| config/examples/nxp-s32k142.config | Added commented example for FOPT override configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Customer confirmed fix: "I tested by pulling your branch and pressing the reset button on our dev board and I can no longer reset the board (which is what we want)". Ready for review/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.