More robust SFTP send/read handling#882
Draft
JacobBarthelmeh wants to merge 3 commits intowolfSSL:masterfrom
Draft
More robust SFTP send/read handling#882JacobBarthelmeh wants to merge 3 commits intowolfSSL:masterfrom
JacobBarthelmeh wants to merge 3 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses robust SFTP send/read handling (ZD21253) by fixing error handling logic and adding extensive testing for large file transfers.
Changes:
- Corrected error handling logic in
wolfSSH_SFTP_SendReadPacketto properly handle retriable vs fatal errors - Updated cache keys in CI workflow to include keygen configuration
- Added comprehensive large file transfer test (3GB file with 10MB chunks)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wolfsftp.c | Fixed inverted error handling logic in 4 locations to properly distinguish between retriable errors (WS_WANT_READ/WRITE) and fatal errors |
| .github/workflows/sftp-test.yml | Updated cache keys, added --enable-keygen to wolfssl build, added new large file transfer test job, and minor whitespace cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD21253