-
Notifications
You must be signed in to change notification settings - Fork 897
Add support for certificate_authorities extension in ClientHello #9209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for certificate_authorities extension in ClientHello #9209
Conversation
🛟 Devin Lifeguard found 2 likely issues in this PR
@mattia-moffa |
94c915c
to
5efc4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the certificate_authorities TLS 1.3 extension in ClientHello messages, enabling clients to inform servers about supported certificate authorities for server authentication. It also adds corresponding API functions and documentation for managing CA lists.
- Implements certificate_authorities extension support for TLS 1.3 ClientHello
- Adds new API functions for managing CA lists (*_set0_CA_list, *_get0_CA_list, *_get0_peer_CA_list)
- Includes comprehensive test coverage for both certificate request and client hello scenarios
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
wolfssl/ssl.h | Adds new API function declarations for CA list management |
wolfssl/openssl/ssl.h | Defines OpenSSL compatibility macros for new functions |
wolfssl/internal.h | Updates internal macros and adds new CA list member variables |
tests/api/test_tls_ext.h | Declares new test functions for certificate authorities extension |
tests/api/test_tls_ext.c | Implements comprehensive tests for extension functionality |
tests/api.c | Registers new test functions |
src/tls13.c | Moves certificate callback invocation for better extension handling |
src/tls.c | Updates extension handling to support client-side certificate authorities |
src/ssl.c | Implements new CA list management functions |
src/internal.c | Updates resource management and initialization for new CA list fields |
doc/dox_comments/header_files/ssl.h | Adds detailed Doxygen documentation for new functions |
Comments suppressed due to low confidence (2)
doc/dox_comments/header_files/ssl.h:1
- Fix the typo 'previosusly' to 'previously' on line 15326.
/*!
doc/dox_comments/header_files/ssl.h:1
- Fix the typo 'previosusly' to 'previously' on line 15429.
/*!
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Copilot found this |
1c594cd
to
4535572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Retest this please StreamCorruptedException |
Description
This adds support for the certificate_authorities TLS 1.3 extension in
ClientHello
, allowing clients to inform servers about the certificate authorities they support for server authentication. Also adds some Doxygen documentation for a few related previously undocumented functions.Fixes zd#20401
Testing
Checklist