[WOOMOB-1032][Woo POS][Settings] Move barcode scanners button to empty cart state #14487

kidinov · 2025-08-19T14:47:44Z

Description

Added barcode scanner setup functionality to the empty cart state in Woo POS. When the cart is empty and the POS settings feature flag is enabled, users can now access barcode scanner settings directly from the cart screen through a dedicated button. The implementation includes automatic navigation to Hardware → Barcode scanners settings with smooth animations and refactored empty state components for better code reusability.

There are also some change in the UI of the empty cart when the flag disabled too, so please evaluate them

Steps to reproduce

Open Woo POS app
Ensure WooPosPosSettingsEnabled feature flag is enabled
Navigate to the cart screen
Ensure cart is empty
Observe the empty cart state now shows both product adding options and barcode scanning setup
Click "Set up scanner" button
Verify navigation goes to Settings → Hardware → Barcode scanners

Testing information

Tested on empty cart state with feature flag enabled/disabled
Verified navigation flow from cart to barcode scanner settings
Confirmed smooth animations during multi-level navigation
Tested UI layout and spacing consistency
Verified accessibility support for screen readers

The tests that have been performed

Manual testing of the empty cart UI layout
Navigation flow testing from cart to settings
Feature flag toggle testing
Code refactoring verification for EmptyStateSection component
Import cleanup and formatting validation

Images/gif

08-20--09-41.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

…I for empty cart state

…destination, enhancing navigation logic

…nent and update icons for barcode scanning

…t icon sizes for better UI consistency

…her navigation

wpmobilebot · 2025-08-19T14:54:01Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`d8b93d9`
	Direct Download	`woocommerce-wear-prototype-build-pr14487-d8b93d9.apk`

wpmobilebot · 2025-08-19T15:11:54Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`d8b93d9`
	Direct Download	`woocommerce-prototype-build-pr14487-d8b93d9.apk`

…ove UI consistency

codecov-commenter · 2025-08-20T13:52:47Z

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.92%. Comparing base (16bc6c2) to head (d8b93d9).
⚠️ Report is 226 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...android/ui/woopos/home/cart/WooPosCartViewModel.kt	40.00%	3 Missing ⚠️
...e/android/ui/woopos/home/cart/WooPosCartUIEvent.kt	0.00%	1 Missing ⚠️
...d/ui/woopos/home/toolbar/WooPosToolbarViewModel.kt	0.00%	1 Missing ⚠️
...ndroid/ui/woopos/root/navigation/WooPosRootHost.kt	0.00%	1 Missing ⚠️
...gs/details/hardware/WooPosSettingsHardwareState.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #14487   +/-   ##
=========================================
  Coverage     37.92%   37.92%           
- Complexity     9329     9330    +1     
=========================================
  Files          2015     2015           
  Lines        113218   113223    +5     
  Branches      14984    14985    +1     
=========================================
+ Hits          42942    42944    +2     
- Misses        66360    66363    +3     
  Partials       3916     3916

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpmobilebot · 2025-08-22T07:57:31Z

Version 23.1 has now entered code-freeze, so the milestone of this PR has been updated to 23.2.

Copilot

Pull Request Overview

This PR implements barcode scanner setup functionality in the empty cart state of Woo POS. When the POS settings feature flag is enabled, users can now access barcode scanner settings directly from an empty cart through a dedicated button, improving the user experience by providing immediate access to scanner configuration.

Added barcode scanner setup button to empty cart state when feature flag is enabled
Refactored navigation events to support hierarchical settings navigation with smooth animations
Updated empty cart UI with enhanced design including OR divider and dual-option layout

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
WooPosCartScreen.kt	Redesigned empty cart UI with barcode scanner setup option and refactored components
WooPosCartViewModel.kt	Added feature flag integration and barcode setup click handling
WooPosSettingsNavigation.kt	Added new route for direct navigation to barcode scanner settings
WooPosSettingsScreen.kt	Implemented automatic navigation with delays for smooth multi-level transitions
WooPosHomeChildToParentCommunication.kt	Refactored navigation events to support hierarchical settings structure
strings.xml	Added new UI strings for barcode scanner setup functionality
ic_woo_pos_empty_cart.xml	Removed custom cart icon in favor of Material Design icons

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/WooPosSettingsScreen.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartScreen.kt

samiuelson

Overall, LGTM! I'd prefer to get rid of delays in Compose layout because, to me, the effect is weird.

samiuelson · 2025-08-22T12:23:04Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/WooPosSettingsScreen.kt

+            val navigationPath = buildNavigationPath(initial.second)
+
+            for (destination in navigationPath) {
+                delay(300)


❓ Hm. I'm not convinced of these delays. I really like the UI effect more without delays.

Yep, me nether. I won't change it now as we may want to change and open the setup flow directly. I won't merge the PR yet

Removed that

samiuelson · 2025-08-22T12:24:24Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/WooPosSettingsScreen.kt


 @Composable
 fun WooPosSettingsScreen(
    onNavigationEvent: (WooPosNavigationEvent) -> Unit,
+    initial: Pair<WooPosSettingsCategory, WooPosSettingsDetailDestination>? = null,


Suggested change

initial: Pair<WooPosSettingsCategory, WooPosSettingsDetailDestination>? = null,

destination: Pair<WooPosSettingsCategory, WooPosSettingsDetailDestination>? = null,

initial is not intuitive, how about destination, initialState, etc?

Good point. Won't change it yet as maybe I need to remove it complete if we go with opening the setup flow dialog from the empty state cart

Removed this too

…larity and consistency

kidinov added 10 commits August 19, 2025 15:13

Move barcode scanners button to empty cart state and enable feature flag

8049889

Refactor settings navigation to include barcode scanners and update U…

012e6c1

…I for empty cart state

Refactor WooPosSettingsScreen to use a Pair for initial category and …

837dfda

…destination, enhancing navigation logic

Add barcode scanning section to empty cart state and refactor layout

2c44f5c

Refactor empty cart sections to use a unified EmptyStateSection compo…

dc7b9ea

…nent and update icons for barcode scanning

Clean up unused imports and fix code formatting issues

5b2efd4

Fix detekt issues: line length and import ordering

f69701e

Refactor WooPosCartScreen to improve button action handling and adjus…

ad7b657

…t icon sizes for better UI consistency

Add delay before category selection in WooPosSettingsScreen for smoot…

8d41320

…her navigation

Add delay before category selection in WooPosSettingsScreen for smoot…

b15a50e

…her navigation

Refactor WooPosCartScreen to consolidate empty cart sections and impr…

e609c04

…ove UI consistency

kidinov requested a review from samiuelson August 20, 2025 07:48

kidinov added the feature: POS label Aug 20, 2025

kidinov added this to the 23.1 milestone Aug 20, 2025

kidinov marked this pull request as ready for review August 20, 2025 07:50

Fixed unit tests

b980908

wpmobilebot modified the milestones: 23.1, 23.2 Aug 22, 2025

samiuelson self-assigned this Aug 22, 2025

samiuelson requested a review from Copilot August 22, 2025 11:44

Copilot AI reviewed Aug 22, 2025

View reviewed changes

samiuelson approved these changes Aug 22, 2025

View reviewed changes

kidinov added 3 commits August 25, 2025 13:15

Removed path to settings from the empty cart screen

ebde73a

Rename BarcodeInfoMenuItemClicked to SetupBarcodeScannerClicked for c…

5635a02

…larity and consistency

Fixed broken tests

d8b93d9

kidinov enabled auto-merge August 25, 2025 12:30

kidinov merged commit f2d2202 into trunk Aug 25, 2025
17 checks passed

kidinov deleted the woomob-1032-woo-possettings-move-barcode-scanners-button-to-the-empty branch August 25, 2025 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WOOMOB-1032][Woo POS][Settings] Move barcode scanners button to empty cart state #14487

[WOOMOB-1032][Woo POS][Settings] Move barcode scanners button to empty cart state #14487

Uh oh!

kidinov commented Aug 19, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 19, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 19, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Aug 20, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samiuelson left a comment

Uh oh!

samiuelson Aug 22, 2025

Uh oh!

kidinov Aug 25, 2025

Uh oh!

kidinov Aug 25, 2025

Uh oh!

samiuelson Aug 22, 2025

Uh oh!

kidinov Aug 25, 2025

Uh oh!

kidinov Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

	initial: Pair<WooPosSettingsCategory, WooPosSettingsDetailDestination>? = null,
	destination: Pair<WooPosSettingsCategory, WooPosSettingsDetailDestination>? = null,

[WOOMOB-1032][Woo POS][Settings] Move barcode scanners button to empty cart state #14487

[WOOMOB-1032][Woo POS][Settings] Move barcode scanners button to empty cart state #14487

Uh oh!

Conversation

kidinov commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

wpmobilebot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wpmobilebot commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samiuelson left a comment

Choose a reason for hiding this comment

Uh oh!

samiuelson Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kidinov commented Aug 19, 2025 •

edited

Loading

wpmobilebot commented Aug 19, 2025 •

edited

Loading

wpmobilebot commented Aug 19, 2025 •

edited

Loading

codecov-commenter commented Aug 20, 2025 •

edited

Loading