-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1474][Woo POS][Surveys] Add analytics tracking for survey notifications. Remove feature flag #14751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kidinov
wants to merge
5
commits into
trunk
Choose a base branch
from
woomob-1474-woo-possurveys-add-analytics
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
malinajirka
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Base automatically changed from
woomob-1452-woo-possurveys-implement-a-click-on-the-notifications-to
to
trunk
October 15, 2025 08:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: tracks
Related to analytics, including Tracks Events.
feature: POS
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1474
Description
Updated the notification type values for WooCommerce POS survey notifications and removed the feature flag
WOO_POS_SURVEYS
.The local notification infrastructure already has built-in tracking in
LocalNotificationScheduler
via:LOCAL_NOTIFICATION_DISPLAYED
- tracked inLocalNotificationWorker
when notifications are shownLOCAL_NOTIFICATION_TAPPED
- tracked inMainActivityViewModel
when notifications are clickedBoth events track the notification type, which now properly identifies WooCommerce POS survey notifications:
WooPosSurveyPotentialUserNotification
uses typewoo_pos_survey_potential_user_survey
WooPosSurveyCurrentUserNotification
uses typewoo_pos_survey_current_user_survey
Steps to reproduce
LOCAL_NOTIFICATION_DISPLAYED
andLOCAL_NOTIFICATION_TAPPED
are tracked with the correct typeTesting information
Verify
LOCAL_NOTIFICATION_DISPLAYED
is tracked with proper type when notifications are shownVerify
LOCAL_NOTIFICATION_TAPPED
is tracked with proper type when notifications are clickedConfirm notification types correctly identify potential vs current user surveys
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.