Skip to content

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Oct 14, 2025

WOOMOB-1474

Description

Updated the notification type values for WooCommerce POS survey notifications and removed the feature flag WOO_POS_SURVEYS.

The local notification infrastructure already has built-in tracking in LocalNotificationScheduler via:

  • LOCAL_NOTIFICATION_DISPLAYED - tracked in LocalNotificationWorker when notifications are shown
  • LOCAL_NOTIFICATION_TAPPED - tracked in MainActivityViewModel when notifications are clicked

Both events track the notification type, which now properly identifies WooCommerce POS survey notifications:

  • WooPosSurveyPotentialUserNotification uses type woo_pos_survey_potential_user_survey
  • WooPosSurveyCurrentUserNotification uses type woo_pos_survey_current_user_survey

Steps to reproduce

  1. Enable notifications
  2. Trigger a survey notification (either for potential or current user) after order creation or after using the POS and then opening the app and waiting for 5 mins
  3. Observe the notification is displayed
  4. Click on the notification
  5. Verify analytics events LOCAL_NOTIFICATION_DISPLAYED and LOCAL_NOTIFICATION_TAPPED are tracked with the correct type

Testing information

  • Verify LOCAL_NOTIFICATION_DISPLAYED is tracked with proper type when notifications are shown

  • Verify LOCAL_NOTIFICATION_TAPPED is tracked with proper type when notifications are clicked

  • Confirm notification types correctly identify potential vs current user surveys

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov changed the title [WOOMOB-1474][Woo POS][Surveys] Add analytics tracking for survey notifications [WOOMOB-1474][Woo POS][Surveys] Add analytics tracking for survey notifications. Remove feature flag Oct 14, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 14, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit365cc3d
Direct Downloadwoocommerce-wear-prototype-build-pr14751-365cc3d.apk

@kidinov kidinov requested a review from malinajirka October 14, 2025 14:14
@kidinov kidinov added feature: POS category: tracks Related to analytics, including Tracks Events. labels Oct 14, 2025
@kidinov kidinov added this to the 23.5 milestone Oct 14, 2025
@kidinov kidinov marked this pull request as ready for review October 14, 2025 14:15
@kidinov kidinov added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 14, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 14, 2025

1 Error
🚫 This PR is tagged with status: do not merge label(s).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 14, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit365cc3d
Direct Downloadwoocommerce-prototype-build-pr14751-365cc3d.apk

@malinajirka malinajirka self-assigned this Oct 14, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from woomob-1452-woo-possurveys-implement-a-click-on-the-notifications-to to trunk October 15, 2025 08:08
@kidinov kidinov modified the milestones: 23.5, 23.6 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: POS status: do not merge Dependent on another PR, ready for review but not ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants