-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1501] Replace wc-analytics/variations with v3/variations endpoint #14757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[WOOMOB-1501] Replace wc-analytics/variations with v3/variations endpoint #14757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the product variations endpoint from the deprecated WooCommerce Analytics API to the standard WooCommerce v3 REST API, requiring WooCommerce 10.3+ for compatibility.
- Replaces
/wc-analytics/variations
with/v3/variations
endpoint - Updates endpoint configuration and API client implementation
- Adds new variations endpoint to the API endpoints list
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
wc-wp-api-endpoints.txt | Adds the new /variations/ endpoint to the API endpoints configuration |
WooPosProductRestClient.kt | Updates the variations fetching method to use the v3 endpoint instead of wc-analytics |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14757 +/- ##
============================================
- Coverage 38.37% 38.37% -0.01%
+ Complexity 10008 10007 -1
============================================
Files 2115 2115
Lines 118142 118142
Branches 15779 15779
============================================
- Hits 45336 45335 -1
Misses 68597 68597
- Partials 4209 4210 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @malinajirka, I'm getting error during variations sync:
E Local Catalog Variations sync failed on page 1: Missing required header in response: Server Date.
E Failed to sync variations: Missing required header in response: Server Date.
E Local catalog FULL sync failed: Missing required header in response: Server Date.. Retrying ...
Could you please try to reproduce it on your end? I just logged into the fresh-installed app and opened POS.
Thanks for looking into this @samiuelson! What version of WooCommerce are you using on your site? The failure seems to suggest the endpoint isn't available. This PR requires version 10.3+ as mentioned in the description. Let me know if you are able to reproduce the issue even 10.3+, thanks! |
#WOOMOB-1501
Description
This PR replaces
/wc-analytics/variations
with/v3/variations
endpoint.Note: WooCommerce 10.3+ is required as the new endpoint isn't available on the previous versions.
Testing information
The tests that have been performed
The above
Images/gif
N/A
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.