-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1385] Booking Pay at location status #14758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3eff029
Add PayAtLocation Booking status
AdamGrzybkowski 19ccb1f
Update badge's background color for PayAtLocation
AdamGrzybkowski 528e000
Fix Today tab date range filter
AdamGrzybkowski f0130fd
Fix condition check for Pay at location status
AdamGrzybkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ class BookingMapper @Inject constructor( | |
name = order.productInfo?.name ?: "-", | ||
customerName = order.customerInfo?.fullName(), | ||
attendanceStatus = BookingAttendanceStatus.BOOKED, | ||
status = status.toUiModel() | ||
status = status.toUiModel(order.status, order.paymentInfo?.paymentMethodId) | ||
) | ||
} | ||
|
||
|
@@ -100,14 +100,23 @@ class BookingMapper @Inject constructor( | |
) | ||
} | ||
|
||
private fun BookingEntity.Status.toUiModel(): BookingStatus = when (this) { | ||
BookingEntity.Status.Paid -> BookingStatus.Paid | ||
BookingEntity.Status.PendingConfirmation -> BookingStatus.PendingConfirmation | ||
BookingEntity.Status.Cancelled -> BookingStatus.Cancelled | ||
BookingEntity.Status.Complete -> BookingStatus.Complete | ||
BookingEntity.Status.Confirmed -> BookingStatus.Confirmed | ||
BookingEntity.Status.Unpaid -> BookingStatus.Unpaid | ||
is BookingEntity.Status.Unknown -> BookingStatus.Unknown(this.key) | ||
private fun BookingEntity.Status.toUiModel( | ||
orderStatus: String?, | ||
paymentMethod: String?, | ||
): BookingStatus { | ||
return if (orderStatus == "completed" && paymentMethod == "cod") { | ||
BookingStatus.PayAtLocation | ||
} else { | ||
when (this) { | ||
Comment on lines
103
to
110
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid magic strings for order status and payment method. Extract 'completed' and 'cod' into well-named constants (or reference existing enums/constants) to centralize these protocol values and prevent typos. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
BookingEntity.Status.Paid -> BookingStatus.Paid | ||
BookingEntity.Status.PendingConfirmation -> BookingStatus.PendingConfirmation | ||
BookingEntity.Status.Cancelled -> BookingStatus.Cancelled | ||
BookingEntity.Status.Complete -> BookingStatus.Complete | ||
BookingEntity.Status.Confirmed -> BookingStatus.Confirmed | ||
BookingEntity.Status.Unpaid -> BookingStatus.Unpaid | ||
is BookingEntity.Status.Unknown -> BookingStatus.Unknown(this.key) | ||
} | ||
} | ||
} | ||
|
||
private fun BookingCustomerInfo.fullName(): String? { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.