-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1513] Fix customer name display when filtering orders from order details #14761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1513] Fix customer name display when filtering orders from order details #14761
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14761 +/- ##
============================================
- Coverage 38.27% 38.27% -0.01%
Complexity 10010 10010
============================================
Files 2118 2118
Lines 118488 118494 +6
Branches 15824 15825 +1
============================================
- Hits 45357 45356 -1
- Misses 68917 68924 +7
Partials 4214 4214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d66ab4e
to
2cdb4db
Compare
2cdb4db
to
033c995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well, thanks for fixing this @kidinov! 🚢
WOOMOB-1513
Fixes an issue where clicking "View customer orders" from order details shows the customer ID instead of the customer name in the filter view.
Changes
OrderFiltersRepository.loadCustomerInfoIfNeeded()
to fetch customer data from API if not in the databaseNotes
If the network request fails or hasn't finished when the filters screen opens, the customer ID will be visible as before. This is the simplest solution that doesn't add too much complexity to the code.
Testing
10-16--10-39.mp4