Skip to content

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Oct 15, 2025

WOOMOB-1513

Fixes an issue where clicking "View customer orders" from order details shows the customer ID instead of the customer name in the filter view.

Changes

  • Added OrderFiltersRepository.loadCustomerInfoIfNeeded() to fetch customer data from API if not in the database
  • Call this method before applying the customer filter so the name can be displayed

Notes

If the network request fails or hasn't finished when the filters screen opens, the customer ID will be visible as before. This is the simplest solution that doesn't add too much complexity to the code.

Testing

  1. Open an order with a customer
  2. Click "View customer orders"
  3. Navigate to the filters screen
  4. Verify customer name is displayed instead of ID
10-16--10-39.mp4

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 15, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 15, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6989282
Direct Downloadwoocommerce-wear-prototype-build-pr14761-6989282.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 15, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6989282
Direct Downloadwoocommerce-prototype-build-pr14761-6989282.apk

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.27%. Comparing base (8956252) to head (6989282).
⚠️ Report is 35 commits behind head on trunk.

Files with missing lines Patch % Lines
...d/ui/orders/filters/data/OrderFiltersRepository.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14761      +/-   ##
============================================
- Coverage     38.27%   38.27%   -0.01%     
  Complexity    10010    10010              
============================================
  Files          2118     2118              
  Lines        118488   118494       +6     
  Branches      15824    15825       +1     
============================================
- Hits          45357    45356       -1     
- Misses        68917    68924       +7     
  Partials       4214     4214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kidinov kidinov force-pushed the woomob-1513-order-list-filtering-by-custom-from-the-order-details-doesnt branch from d66ab4e to 2cdb4db Compare October 16, 2025 07:58
@kidinov kidinov force-pushed the woomob-1513-order-list-filtering-by-custom-from-the-order-details-doesnt branch from 2cdb4db to 033c995 Compare October 16, 2025 08:20
@kidinov kidinov requested a review from toupper October 16, 2025 08:38
@kidinov kidinov added this to the 23.5 milestone Oct 16, 2025
@kidinov kidinov marked this pull request as ready for review October 16, 2025 08:39
@kidinov kidinov changed the title Fix customer name display when filtering orders from order details [WOOMOB-1513] Fix customer name display when filtering orders from order details Oct 16, 2025
Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well, thanks for fixing this @kidinov! :shipit: 🚢

@kidinov kidinov merged commit 3be0abb into trunk Oct 16, 2025
19 of 20 checks passed
@kidinov kidinov deleted the woomob-1513-order-list-filtering-by-custom-from-the-order-details-doesnt branch October 16, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants