Add support for multiple subscriptions #295
Conversation
Adds the required `multiple_subscriptions` feature support, so merchants can purchase multiple subscriptions in one order via PayFast.
Recorded a new potential version with support for multiple subscriptions.
Version bump
| @@ -145,6 +145,7 @@ public function __construct() { | |||
| 'subscription_date_changes', | |||
| 'subscription_payment_method_change', // Subs 1.x support. | |||
| 'subscription_payment_method_change_customer', // Enabled for https://github.com/woocommerce/woocommerce-gateway-payfast/issues/32. | |||
| 'multiple_subscriptions', | |||
There was a problem hiding this comment.
I've not tested things but are there no specific updates needed to support multiple subscriptions, things just work as long as we declare support?
There was a problem hiding this comment.
That is my understanding based on this doc section here, "Step 1.1: Registering Support for Subscription Management Features"
There was a problem hiding this comment.
Reading that section, it shows how to declare support in your extension for each of those subscription features. But we need to be sure multiple subscriptions actually work before we can declare that compatibility. Has testing been done to verify multiple subscriptions works here?
I had manually updated the changelog, not needed as the release process takes care of this.
The version number increase is handled during the release process, I don't need to manually change that.
… to add changelog entries or change the plugin version number. This is all handled by the release process.
|
@ryanr14 thanks for working on this here, please reach out once your updates and testing shows that multiple subscriptions works as expected and ideally that existing Critical Flows pass as well. |
All Submissions:
Changes proposed in this Pull Request:
This would add support for multiple subscriptions in one purchase via Payfast.
Closes PAYFAST-8: Can Payfast Support Multiple Subscriptions
Steps to test the changes in this Pull Request:
Changelog entry