Skip to content

[WIP] PoC: Stripe Transact proxy (plugin changes) #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: dev/jetpack-onboarding-class
Choose a base branch
from
Draft

[WIP] PoC: Stripe Transact proxy (plugin changes) #4748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a9ebfe
retrieve request
Mayisha Oct 23, 2025
ccf42ee
Merge try/extract-transact-proxy-api-logic and refactor to use the ne…
diegocurbelo Oct 25, 2025
401f965
Improve cache handling
diegocurbelo Oct 25, 2025
bac85b8
Fix tests
diegocurbelo Oct 25, 2025
af8d883
Consolidate WPCOM constants in WC_Stripe_Transact_API
diegocurbelo Oct 25, 2025
9a5b847
Remove body json_enconde when making a transact_api call
diegocurbelo Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 68 additions & 32 deletions includes/class-wc-stripe-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ class WC_Stripe_API {
/**
* Stripe API Endpoint
*/
const ENDPOINT = 'https://api.stripe.com/v1/';
const STRIPE_API_VERSION = '2024-06-20';
const ENDPOINT = 'https://api.stripe.com/v1/';

/**
* Stripe API Version
*/
public const STRIPE_API_VERSION = '2024-06-20';

/**
* The invalid API key error count cache key.
Expand Down Expand Up @@ -119,19 +123,17 @@ public static function set_secret_key_for_mode( $mode = null ) {
* @version 4.0.0
*/
public static function get_user_agent() {
$app_info = [
'name' => 'WooCommerce Stripe Gateway',
'version' => WC_STRIPE_VERSION,
'url' => 'https://woocommerce.com/products/stripe/',
'partner_id' => 'pp_partner_EYuSt9peR0WTMg',
];

return [
'lang' => 'php',
'lang_version' => phpversion(),
'publisher' => 'woocommerce',
'uname' => function_exists( 'php_uname' ) ? php_uname() : PHP_OS,
'application' => $app_info,
'application' => [
'name' => 'WooCommerce Stripe Gateway',
'version' => WC_STRIPE_VERSION,
'url' => 'https://woocommerce.com/products/stripe/',
'partner_id' => 'pp_partner_EYuSt9peR0WTMg',
],
];
}

Expand All @@ -146,7 +148,7 @@ public static function get_headers() {
$app_info = $user_agent['application'];

$headers = [
'Authorization' => 'Basic ' . base64_encode( self::get_secret_key() . ':' ),
'Authorization' => 'Basic ' . base64_encode( self::get_secret_key() . ':' ),
'Stripe-Version' => self::STRIPE_API_VERSION,
];

Expand Down Expand Up @@ -235,19 +237,32 @@ public static function request( $request, $api = 'charges', $method = 'POST', $w
*/
$request = apply_filters( 'wc_stripe_request_body', $request, $api );

// Log the request after the filters have been applied.
WC_Stripe_Logger::debug( "Stripe API request: {$method} {$api}", [ 'request' => $request ] );
$is_transact_api_enabled = WC_Stripe_Transact_API::get_instance()->is_transact_api_enabled();

$response = wp_safe_remote_post(
self::ENDPOINT . $api,
// Log the request after the filters have been applied.
WC_Stripe_Logger::debug(
"Stripe API request: {$method} {$api}",
[
'method' => $method,
'headers' => $headers,
'body' => $request,
'timeout' => 70,
'transact_api_enabled' => $is_transact_api_enabled,
'request' => $request,
]
);

if ( $is_transact_api_enabled ) {
$response = WC_Stripe_Transact_API::get_instance()->send_wpcom_proxy_request( $method, $api, $headers, $request );

} else {
$response = wp_safe_remote_post(
self::ENDPOINT . $api,
[
'method' => $method,
'headers' => $headers,
'body' => $request,
'timeout' => 70,
]
);
}

$response_headers = wp_remote_retrieve_headers( $response );

if ( is_wp_error( $response ) || empty( $response['body'] ) ) {
Expand All @@ -266,7 +281,13 @@ public static function request( $request, $api = 'charges', $method = 'POST', $w

$response_body = json_decode( $response['body'] );

WC_Stripe_Logger::debug( "Stripe API response: {$method} {$api}", [ 'response' => $response_body ] );
WC_Stripe_Logger::debug(
"Stripe API response: {$method} {$api}",
[
'transact_api_enabled' => $is_transact_api_enabled,
'response' => $response_body,
]
);

if ( $with_headers ) {
return [
Expand Down Expand Up @@ -300,24 +321,32 @@ public static function retrieve( $api ) {
return null;
}

WC_Stripe_Logger::debug( "Stripe API request: GET {$api}" );
$is_transact_api_enabled = WC_Stripe_Transact_API::get_instance()->is_transact_api_enabled();

$response = wp_safe_remote_get(
self::ENDPOINT . $api,
[
'method' => 'GET',
'headers' => self::get_headers(),
'timeout' => 70,
]
);
WC_Stripe_Logger::debug( "Stripe API request: GET {$api}", [ 'transact_api_enabled' => $is_transact_api_enabled ] );

if ( $is_transact_api_enabled ) {
$response = WC_Stripe_Transact_API::get_instance()->send_wpcom_proxy_request( 'GET', $api, self::get_headers() );

} else {
$response = wp_safe_remote_get(
self::ENDPOINT . $api,
[
'method' => 'GET',
'headers' => self::get_headers(),
'timeout' => 70,
]
);
}

// If we get a 401 error, we know the secret key is not valid.
if ( is_array( $response ) && isset( $response['response'] ) && is_array( $response['response'] ) && isset( $response['response']['code'] ) && 401 === $response['response']['code'] ) {
// Stripe redacts API keys in the response.
WC_Stripe_Logger::error(
"Stripe API error: GET {$api} returned a 401",
[
'response' => json_decode( $response['body'] ),
'transact_api_enabled' => $is_transact_api_enabled,
'response' => json_decode( $response['body'] ),
]
);

Expand Down Expand Up @@ -350,15 +379,22 @@ public static function retrieve( $api ) {
WC_Stripe_Logger::error(
"Stripe API error: GET {$api}",
[
'response' => $response,
'transact_api_enabled' => $is_transact_api_enabled,
'response' => $response,
]
);
return new WP_Error( 'stripe_error', __( 'There was a problem connecting to the Stripe API endpoint.', 'woocommerce-gateway-stripe' ) );
}

$response_body = json_decode( $response['body'] );

WC_Stripe_Logger::debug( "Stripe API response: GET {$api}", [ 'response' => $response_body ] );
WC_Stripe_Logger::debug(
"Stripe API response: GET {$api}",
[
'transact_api_enabled' => $is_transact_api_enabled,
'response' => $response_body,
]
);

return $response_body;
}
Expand Down
Loading