-
Notifications
You must be signed in to change notification settings - Fork 118
Order Details: Enhance map picker with search completer region and iOS 17 compatibility #16154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…ilable requirements.
…hance the search relevance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't seem to get the expected results when searching in the app vs when searching in Apple Maps, just a quick example:
Looking for a mall near my place in Apple maps shows it as soon as I type the initial characters, but in the app it never shows (until shows no results found after many characters).
By looking at the mapPosition.region
this seems to be accurate to my current position, but still gives me results from the States, and India as I start typing, until no results are given.

The issue seems to be with MKLocalSearchCompletion
giving a dozen of results, but none of them matching the search intention, not sure how much we can do in this regard. Do you think of anything I can do/change on my end for further testing? Should I expect similar results when comparing with Apple Maps?
For reference, tested in iPad Pro 12.9 inch - iOS 26.0
var isSearchFocused: Bool = false | ||
private(set) var searchResults: [MKLocalSearchCompletion] = [] | ||
var region = MKCoordinateRegion( | ||
var mapPosition: MapCameraPosition = .region(MKCoordinateRegion( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why are we using Cupertino coordinates here? Should we pass in some sort of Location service that uses CLLocationManagerDelegate
for the merchant's location? (I see we already instantiate a CLLocationManager
when configuring the map) Or not really needed?
Generated by 🚫 Danger |
Just one review is required.
Description
This PR enhances the address map picker functionality in order details by setting the map region to the search completer's region to potentially enhance search relevance. Additionally, it fixes iOS 17 warnings related to deprecated Map usage and removes all iOS 17 availability requirements now that the app is iOS 17+.
Previously, Jorge from Kiwi reported an issue from the address map search that resolved itself later p1755255735655679/1755255191.666409-slack-C03L1NF1EA3. While searching for potential causes, it's recommended to set the region to the local search completer so that it prioritizes nearby places. The default region is the world, and it might be too broad for the initial search. I tested that it's still possible to search for addresses in a very far part of the world from the map region.
Steps to reproduce
Testing information
I tested on iOS 18.4 simulator and iOS 26 device.
Screenshots
Whenever I turned on recording mode in either simulator or device, testing steps 8 stopped working due to
MapCameraPosition.region
beingnil
without a clear reason 😓 . Therefore, just sharing a basic screencast of the flow:Simulator.Screen.Recording.-.iPad.A16.-.2025-09-19.at.15.09.57.mov
RELEASE-NOTES.txt
if necessary.