[WCiOS17] Update PaymentMethodsView to not use deprecated NavigationLink init
#16196
Conversation
Seems to crash the previews macro if we do not provide a rootViewController, despite being optional
iamgabrielma
added
type: task
|
|
| .previewDisplayName("Light") | ||
| #Preview("Light") { | ||
| @Previewable @State var rootViewController = UIViewController() | ||
| NavigationView { |
There was a problem hiding this comment.
nit: as NavigationView is deprecated, would be nice to replace it with NavigationStack. Simply replacing it with NavigationStack seems to work. Similarly for other previews in this file.
There was a problem hiding this comment.
That's very true, updated: 84d2e6a
| ) | ||
| .navigationBarTitleDisplayMode(.inline) | ||
| } | ||
| .environment(\.colorScheme, .dark) |
There was a problem hiding this comment.
nit: unrelated to this PR, I think we could just keep one preview here since the differences are just the color scheme and accessibility font size which can be configured in SwiftUI previews. It's more worth having multiple previews when the data/states are different.
There was a problem hiding this comment.
Yeah, that sounds good to me. Updated: 84d2e6a
3 participants
Closes WOOMOB-1406
Description
As with #16195, this PR updates the
PaymentMethodsViewcomponent from Order > Collect Payment to not use deprecatedNavigationLink(isActive:)API for navigation. It also fixes the file previews, which seem to crash in Xcode due missing dependencies.Changes
NavigationLink(isActive:in favor of.navigationDestination(isPresented:view modifierTesting information
Cashas payment methodScreenshots