[Local Catalog] Show items from GRDB in POS #16235
+476
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| import Foundation | ||
| import Observation | ||
| import class WooFoundation.CurrencySettings | ||
| import enum Yosemite.POSItem | ||
| import protocol Yosemite.POSObservableDataSourceProtocol | ||
| import struct Yosemite.POSVariableParentProduct | ||
| import class Yosemite.GRDBObservableDataSource | ||
| import protocol Storage.GRDBManagerProtocol | ||
|
|
||
| /// Controller that wraps an observable data source for POS items | ||
| /// Uses computed state based on data source observations for automatic UI updates | ||
| @Observable | ||
| final class PointOfSaleObservableItemsController: PointOfSaleItemsControllerProtocol { | ||
| private let dataSource: POSObservableDataSourceProtocol | ||
|
|
||
| // Track which items have been loaded at least once | ||
| private var hasLoadedProducts = false | ||
| private var hasLoadedVariationsForCurrentParent = false | ||
|
|
||
| // Track current parent for variation state mapping | ||
| private var currentParentItem: POSItem? | ||
|
|
||
| var itemsViewState: ItemsViewState { | ||
| ItemsViewState( | ||
| containerState: containerState, | ||
| itemsStack: ItemsStackState( | ||
| root: rootState, | ||
| itemStates: variationStates | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| init(siteID: Int64, | ||
| grdbManager: GRDBManagerProtocol, | ||
| currencySettings: CurrencySettings) { | ||
| self.dataSource = GRDBObservableDataSource( | ||
| siteID: siteID, | ||
| grdbManager: grdbManager, | ||
| currencySettings: currencySettings | ||
| ) | ||
| } | ||
|
|
||
| // periphery:ignore - used by tests | ||
| init(dataSource: POSObservableDataSourceProtocol) { | ||
| self.dataSource = dataSource | ||
| } | ||
|
|
||
| func loadItems(base: ItemListBaseItem) async { | ||
| switch base { | ||
| case .root: | ||
| hasLoadedProducts = true | ||
| dataSource.loadProducts() | ||
| case .parent(let parent): | ||
| guard case .variableParentProduct(let parentProduct) = parent else { | ||
| assertionFailure("Unsupported parent type for loading items: \(parent)") | ||
| return | ||
| } | ||
|
|
||
| // If switching to a different parent, reset the loaded flag | ||
| if currentParentItem != parent { | ||
| currentParentItem = parent | ||
| hasLoadedVariationsForCurrentParent = false | ||
| } | ||
|
|
||
| hasLoadedVariationsForCurrentParent = true | ||
| dataSource.loadVariations(for: parentProduct) | ||
| } | ||
| } | ||
|
|
||
| func refreshItems(base: ItemListBaseItem) async { | ||
| switch base { | ||
| case .root: | ||
| dataSource.refresh() | ||
|
There was a problem hiding this comment. So, this is not implemented. Is the idea to trigger an incremental sync when refresh is called? |
||
| case .parent(let parent): | ||
| guard case .variableParentProduct(let parentProduct) = parent else { | ||
| assertionFailure("Unsupported parent type for refreshing items: \(parent)") | ||
| return | ||
| } | ||
| dataSource.loadVariations(for: parentProduct) | ||
| } | ||
| } | ||
|
|
||
| func loadNextItems(base: ItemListBaseItem) async { | ||
| switch base { | ||
| case .root: | ||
| dataSource.loadMoreProducts() | ||
| case .parent: | ||
| dataSource.loadMoreVariations() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - State Computation | ||
| private extension PointOfSaleObservableItemsController { | ||
| var containerState: ItemsContainerState { | ||
| // Use .loading during initial load, .content otherwise | ||
| if !hasLoadedProducts && dataSource.isLoadingProducts { | ||
| return .loading | ||
| } | ||
| return .content | ||
| } | ||
|
|
||
| var rootState: ItemListState { | ||
| let items = dataSource.productItems | ||
|
|
||
| // Initial state - not yet loaded | ||
| if !hasLoadedProducts { | ||
| return .initial | ||
| } | ||
|
|
||
| // Loading state - preserve existing items | ||
| if dataSource.isLoadingProducts { | ||
| return .loading(items) | ||
| } | ||
|
|
||
| // Error state | ||
| if let error = dataSource.error, items.isEmpty { | ||
|
There was a problem hiding this comment. What kind of errors can we expect here? Since this comes from database, only something super-unexpected I suppose? |
||
| return .error(.errorOnLoadingProducts(error: error)) | ||
| } | ||
|
|
||
| // Empty state | ||
| if items.isEmpty { | ||
| return .empty | ||
| } | ||
|
|
||
| // Loaded state | ||
| return .loaded(items, hasMoreItems: dataSource.hasMoreProducts) | ||
| } | ||
|
|
||
| var variationStates: [POSItem: ItemListState] { | ||
| guard let parentItem = currentParentItem else { | ||
| return [:] | ||
| } | ||
|
|
||
| let items = dataSource.variationItems | ||
|
|
||
| // Initial state - not yet loaded | ||
| if !hasLoadedVariationsForCurrentParent { | ||
| return [parentItem: .initial] | ||
| } | ||
|
|
||
| // Loading state - preserve existing items | ||
| if dataSource.isLoadingVariations { | ||
| return [parentItem: .loading(items)] | ||
| } | ||
|
|
||
| // Error state | ||
| if let error = dataSource.error, items.isEmpty { | ||
| return [parentItem: .error(.errorOnLoadingVariations(error: error))] | ||
| } | ||
|
|
||
| // Empty state | ||
| if items.isEmpty { | ||
| return [parentItem: .empty] | ||
| } | ||
|
|
||
| // Loaded state | ||
| return [parentItem: .loaded(items, hasMoreItems: dataSource.hasMoreVariations)] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delay it until the items are loaded? Same with other similar flags.