-
Notifications
You must be signed in to change notification settings - Fork 118
[Woo POS][Surveys] Make PointOfSaleNotificationScheduler
for initial eligibility schedule triggers
#16238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Surveys] Make PointOfSaleNotificationScheduler
for initial eligibility schedule triggers
#16238
Conversation
|
…tionIfEligible async scheduleLocalNotification calling a Task creates a detached task since the func itself is sync. Since is not running in the task context, this makes tests fail as they finish before the observation closure is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Nice! Tidy work 👍
} | ||
|
||
// periphery: ignore - work in progress | ||
final class PointOfSaleNotificationScheduler: PointOfSaleNotificationScheduling { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit; We haven't renamed everything yet, but I think we decided to call things with POS
prefix
final class PointOfSaleNotificationScheduler: PointOfSaleNotificationScheduling { | |
final class POSNotificationScheduler: POSNotificationScheduling { |
Partially closes WOOMOB-1458
Partially closes WOOMOB-1460
Description
This PR centralizes POS surveys notification eligibility and scheduling in a single
PointOfSaleNotificationScheduler
place, and adds the initial eligibility conditions (feature flag and country).Testing information
The class is currently unused, in order to test:
EditableOrderViewModel.onCreateOrderTapped()
:PointOfSaleNotificationScheduler.timeIntervalInSeconds.potentialMerchant
to 5 seconds or so:Screenshots
2025-10-14.trigger.notification.on.order.creation.mov