Skip to content

[IPPInAppFeedback] Add feature flag for IPP in-app feedback banner #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

[IPPInAppFeedback] Add feature flag for IPP in-app feedback banner #8529

merged 1 commit into from
Jan 4, 2023

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jan 3, 2023 •
edited
Loading

Part of #8530

Description

As part of the work needed for adding the IPP in-app feedback banner ( pdfdoF-20T-p2 ), we're adding a feature flag to hide any changes behind it while is being worked on.

Changes

Adds the .IPPInAppFeedbackBanner feature flag

@iamgabrielma iamgabrielma added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Jan 3, 2023
@iamgabrielma iamgabrielma added this to the 11.8 milestone Jan 3, 2023
@iamgabrielma iamgabrielma mentioned this pull request Jan 3, 2023
Closed
16 tasks
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 3, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8529-8f3ef6d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamgabrielma iamgabrielma requested a review from toupper January 3, 2023 11:36
@toupper
Copy link
Contributor

toupper commented Jan 4, 2023

The party starts, LGTM :shipit:

@iamgabrielma iamgabrielma merged commit 0fadd94 into trunk Jan 4, 2023
@iamgabrielma iamgabrielma deleted the task/ippiaf-add-feature-flag branch January 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toupper toupper toupper approved these changes

Assignees

No one assigned

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

4 participants

@iamgabrielma @wpmobilebot @toupper