Fastfile clean-up #9834
Fastfile clean-up #9834
Conversation
spencertransier
added
the
category: tooling
| def fastlane_directory | ||
| __dir__ | ||
| end | ||
|
|
||
| def derived_data_directory | ||
| File.join(fastlane_directory, 'DerivedData') | ||
| end | ||
|
|
||
| def screenshots_directory | ||
| File.join(fastlane_directory, 'screenshots') | ||
| end | ||
|
|
||
| def screenshot_devices | ||
| [ | ||
| 'iPhone 11 Pro Max', | ||
| 'iPhone 8 Plus', | ||
| 'iPad Pro (12.9-inch) (2nd generation)', | ||
| 'iPad Pro (12.9-inch) (3rd generation)' | ||
| ] | ||
| end | ||
|
|
||
| def simulator_version | ||
| '14.4' | ||
| end | ||
|
|
There was a problem hiding this comment.
The values in these methods were already stored in constants at the top of the Fastfile. I verified that they aren't being used anywhere.
| xcversion() # Ensure we're using the right version of Xcode, defined in `.xcode-version` file | ||
| xcversion # Ensure we're using the right version of Xcode, defined in `.xcode-version` file |
There was a problem hiding this comment.
I know xcversion has been deprecated in favor of xcodes, but I decided to hold off on switching over to xcodes until I could fully test out the change.
There was a problem hiding this comment.
Related: Andrew is working on updating from xcversion to xcodes in Tumblr iOS too.
As I mentioned in my comment over there, I remember that we had issues with xcodes vs Apple APIs now being authenticated back when @mokagio tried to migrate WCiOS to xcodes on Nov 22 and that's why that Draft PR was never merged.
I'm hoping that all of this has been fixed in xcodes/fastlane since all that (this comment makes me hopeful that it was) so I'm hoping this won't cause any issue anymore, but worth double-checking to be sure anyway—and maybe coordinate with Andrew's testing it on Tumblr-iOS to share your conclusions?
| ##################################################################################### | ||
| # register_new_device | ||
| # ----------------------------------------------------------------------------------- | ||
| # This lane helps a developer register a new device in the App Store Portal | ||
| # ----------------------------------------------------------------------------------- | ||
| # Usage: | ||
| # bundle exec fastlane register_new_device | ||
| # | ||
| # Example: | ||
| # bundle exec fastlane register_new_device | ||
| ##################################################################################### |
There was a problem hiding this comment.
Replaced by the MC tool.
fastlane/Fastfile
Outdated
| repository: GITHUB_REPO, | ||
| milestone: new_version | ||
| ) | ||
| ios_check_beta_deps(podfile: File.join(PROJECT_ROOT_FOLDER, 'Podfile') |
There was a problem hiding this comment.
Missing an closing ) at the end.
You can test the changes from this Pull Request by:
|
4 participants
This PR changes a few things in the
Fastfile(and minor changes to thePodfileandGemfile):File.joinregister_new_devicelane because it's been replaced by the MC tool