Ciena 8190 (SAOS 10.x) backend - #265
Merged
hanstrompert merged 3 commits intoApr 1, 2026
Merged
Conversation
hanstrompert
force-pushed
the
backend-ciena8190
branch
from
November 20, 2025 17:19
4914d51 to
6b42432
Compare
Member
|
Hi @andriilytvynov, thank you for sharing this backend! The code looks great. We try to keep the formatting, coding style and the level of annotations consistent, would it be possible for you to fix the output of |
Contributor
Author
|
Sure! Will do, Hans! |
Contributor
Author
|
@hanstrompert formatting, style and annotations are fixed |
- Add missing class docstrings for BackendSettings, Backend, and __init__
- Add closing punctuation to all docstring first lines (D415)
- Replace str.format() with %-style formatting in log statement (G001)
- Remove unnecessary list wrapper in any() call (C419)
- Replace set([...]) with set comprehension {...} (C403)
- Remove explicit return None in deactivate method (RET501)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Hi @andriilytvynov, I am so sorry that I let this sit for so long. I recently switched from black/isort/flake8 to ruff, I have updated your pull request accordingly. Thanks again for sharing this backend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend for Ciena 8190, SAOS 10; actions supported: activate, deactivate, terminate.