Fix to parse _n and _nx, add command line option --translation-domains for filtering translations.#76
Conversation
|
The descriptions of the command line options |
|
Ok, thank you! I'll try to take a look at it as soon as possible. I just ask you to be patient in the meantime. As for the descriptions of the commands you mention (domain, ignore-domain), do you have any proposals on how? |
|
Sorry for the late reply. |
|
I've made some fixes to include your comments. And I've modified the description of |
|
@chrono-meter really a nice job! Thank you again for your contribution! ps. please next time (because i hope there is a next time 😉) make you modification in a new branch, and push multiple PR if required. In this case, since there were two different changes, I would have preferred two separate PRs, one for _n and _nx and the translation domain. It's no big deal, I do the same thing, but from the reviewer's point of view, it would have been clearer to have two separate ones. |
Fixed a bug in parsing
_nand_nxwhere the argument order was handled incorrectly.Also, if parsing fails, an error is output and no entry is generated. This is probably the correct behavior.
Added command line option
--translation-domains.This is useful when we want to use translations for our own domains in combination with translations for the
defaultdomain.